Re: Patch for squid-2 to better detect spnego support for squid_kerb_auth

"Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
news:4A76CD57.4080408_at_treenet.co.nz...
> Markus Moeller wrote:
>> The attached patch is against the latest cvs and brings squid 2 in line
>> with squid 3.
>>
>> Regards
>> Markus
>
> Have the two comments I stuck in there for Squid-3 about syncing the
> buffer magic numbers been checked against the Squid-2 magic values?
>
> It kind of looks like the token len at least was 64KB in Squid-2...
>

As long as squid_kerb_auth has a bigger buffer then defined in
auth_negotiate.c(c) it should be fine. The theortical maximum is 64k if I
remember right for data in an uathentication header or ?

>
> // AYJ: must match the definition in src/auth/negotiate/auth_negotiate.cc
> +#define MAX_AUTHTOKEN_LEN 32768
> +
> +// AYJ: match define in include/rfc2181.h
> #ifndef HOST_NAME_MAX
> #define HOST_NAME_MAX 256
> #endif
> #ifndef MAXHOSTNAMELEN
> #define MAXHOSTNAMELEN HOST_NAME_MAX
> #endif
>
>
> Amos
> --
> Please be using
> Current Stable Squid 2.7.STABLE6 or 3.0.STABLE17
> Current Beta Squid 3.1.0.12
>
Received on Mon Aug 03 2009 - 13:08:19 MDT