[PATCH] Bug 2680: ** helper errors after -k rotate

Amos Jeffries wrote:
> Robert Collins wrote:
>> On Wed, 2009-07-15 at 00:52 +0200, Henrik Nordstrom wrote:
>>> Or 4, go back to don't strictly enforce the number of helpers?
>>
>> +1
>>
>> I don't know what this strictly-enforce thing is, but it sounds unneeded
>> as we used to fire up the right number of helpers anyway.
>
> I stopped Squid saying:
> "running: 200 of 100 XXX helpers"
>
>
> A Henrik said,
> people with large memory-hog helpers have issues when Squid allocates
> more than N bunches of their carefully tuned available memory to its
> helpers. This is also important in low-memory systems requiring auth.
>
> It's a simple 'start N' call now checks the number of running helpers
> before blindly starting new ones. Making Squid actually follow its
> numerous children=N settings.
>
>
> I'm fine with reverting it in 3.1. But this is a nasty mix of sync and
> async operations that does need cleaning up in 3.2. It's semi-hiding
> about 4 bugs in a helpers and auth.
>

Right, following up on that I had a hunch and discovered that n_active
is already performing this duty. The bug is therefore in my earlier fix
using n_running as a base instead of n_active.

How does this new attached patch look to you two?
It performs the calculation re-base and documents the relevant counters.

Amos