Re: [PATCH] Enhanced access logging, added ICAP logging, bug #2495 fix.

Hi Amos,
   I post the new patch.
I think I made most of the changes you are requested.
I did not do the following changes:
> ** Please make fqdncache_entry / ipcache_entry public classes
instead
> of functional structs. Some gcc complain and doxygen won't document
> their functions properly.

and
>> I spy a goto that can die...
>> case CLF_NONE:
>> goto last;
>> @@ -1458,7 +1863,15 @@
>> last:
>> (void)0; /* NULL statement for label */
>> +}
>>
>> ==> equates to "return;". Please check for others in that same function.

I have not any special reason and I will do the changes if required, but
it is better for now to focus on new features added. Other changes can
applied with separate patches....

I hope it is OK.

Regards,
     Christos
Received on Fri Jul 10 2009 - 07:55:39 MDT