Re: Sbuf review at r9331

On 02/23/2009 10:52 AM, Kinkie wrote:

>> * Declare when needed, for example inside for():
>> size_type j;
>> for (j=0;j<len_;j++) {
>
> Do you mean that this should read
> for (size_type j=0;j<len_;++j)
> ?

Yes, I do. IIRC, there are many other examples where variables are
declared too early. This is a minor flaw, with no real effect in most
cases, but it is a good habit to develop and becomes important when you
deal with non-integral variables.

> Next steps, mempooling SBufStore and its backing storage.

MemPooling is needed but does not affect the design or most of the
implementation code. There is no serious rush to implement this, IMO.

It looks like all the big items in the previews review are closed. Do
you want me to do another review soon or should I wait for some other
milestone/event?

Thank you,

Alex.
Received on Mon Feb 23 2009 - 22:58:15 MST