Re: [MERGE] First string-fix merge

Kinkie wrote:
> On Sat, Jan 31, 2009 at 7:33 PM, Tsantilas Christos
> <chtsanti_at_users.sourceforge.net> wrote:
>> Hi Francesco,
>> I have some problems trying to compile the string-fix branch.
>>
>> with --enable-icap-client I am getting:
>> ICAPOptions.cc: In member function 'bool
>> ICAPOptions::TransferList::matches(const String&) const':
>> ICAPOptions.cc:179: error: passing 'const String' as 'this' argument of
>> 'char& String::operator[](unsigned int)' discards qualifiers
>> with --enable-x-accelerator-vary:
>> store.cc: In member function 'void StoreEntry::setPublicKey()':
>> store.cc:699: error: 'class String' has no member named 'buf'
>> store.cc:701: error: 'class String' has no member named 'buf'
>> with --enable-esi :
>> ESI.cc: In member function 'virtual esiProcessResult_t
>> esiLiteral::process(int)':
>> ESI.cc:1581: error: 'class ESISegment' has no member named 'unsafeBuf'
>> ESI.cc: In function 'int esiEnableProcessing(HttpReply*)':
>> ESI.cc:2433: error: 'class String' has no member named 'buf'
>
> Weird.. I'm not getting those using the test-suite.sh, and I'd expect
> that it'd catch them. In fact, I'm building with the options used for
> the layer-02 test...
> Thanks for letting me know.
> I'll retire the merge request and resubmit after those are fixed -
> hopefully tomorrow.
>
>> I am able to compile it (and use it) with the following options:
>>
>> ./configure --with-pthreads --enable-icmp --enable-linux-netfilter
>> --with-large-files --prefix=/usr/local/squid3-cvs/ --enable-snmp
>> --enable-delay-pools--enable-arp-acl --enable-ssl
>> --enable-storeio=ufs,aufs,diskd
>> --enable-disk-io=AIO,Blocking,DiskDaemon,DiskThreads
>> --enable-auth=basic,digest,negotiate,ntlm
>> --enable-basic-auth-helpers=NCSA,LDAP
>> --enable-digest-auth-helpers=ldap,password --with-filedescriptors=16384
>
> Thanks.
>

ESI I'm not surprised. It's not yet tested properly since it has a
system-specific dependency.

x-accelerator-vary appears to be missing from the tests. Fixing.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE5 or 3.0.STABLE12
   Current Beta Squid 3.1.0.4