Re: /bzr/squid3/trunk/ r9446: Regression Fix: rollback bug 2395 fix.

Hi all,
   I'm testing this on eu NOW (via 3.1-BZR). Doesn't seem to be working.

   Kinkie

On Fri, Jan 23, 2009 at 2:59 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> ------------------------------------------------------------
> revno: 9446
> committer: Amos Jeffries <squid3_at_treenet.co.nz>
> branch nick: trunk
> timestamp: Fri 2009-01-23 14:59:29 +1300
> message:
> Regression Fix: rollback bug 2395 fix.
>
> Fixing bug 2395 uncovered a much more serious bug 2558.
> It was not found earlier due to bug 2558 being a slow incremental affect
> hidden by already-cached objects.
>
> This rollback is intended as a temporary measure until a good fix can be
> found for both bugs.
> modified:
> src/forward.cc
>
> === modified file 'src/forward.cc'
> --- a/src/forward.cc 2009-01-13 05:28:23 +0000
> +++ b/src/forward.cc 2009-01-23 01:59:29 +0000
> @@ -332,10 +332,8 @@
> startComplete(servers);
> } else {
> debugs(17, 3, "fwdComplete: server FD " << server_fd << " not re-forwarding status " << entry->getReply()->sline.status);
> - if (entry->isEmpty() && !err) {
> - EBIT_CLR(entry->flags, ENTRY_FWD_HDR_WAIT);
> - entry->complete();
> - }
> + EBIT_CLR(entry->flags, ENTRY_FWD_HDR_WAIT);
> + entry->complete();
>
> if (server_fd < 0)
> completed();
>
>
>

-- 
    /kinkie