Re: [PATCH] WCCPv2 documentation and cleanup for bug 2404

Amos Jeffries wrote:
> Adrian Chadd wrote:
>> Have you tested these changes against various WCCPv2 implementations?
>>
>> I do recall some structure definitions in the draft mis-matching the
>> wide number of IOS versions out there, this is why I'm curious.
>>
>
> I have no testing capability. Thus I'm not committing until someone can
> confirm it works.

PS. I found your notes in the mask structure and the way received masks
appears to operate does look markedly different to the draft. I haven't
touched that one other than to document the anomaly a bit more.

Amos

>>
>> Adrian
>>
>> 2009/1/10 Amos Jeffries <squid3_at_treenet.co.nz>:
>>> This patch:
>>> - adds a reference to each struct mentioning the exact draft
>>> RFC section where that struct is defined.
>>> - fixes sent mask structure fields to match draft. (bug 2404)
>>> - removes two duplicate useless structs
>>>
>>> Submitting as a patch to give anyone interested time to double-check the
>>> code changes.
>>>
>>>
>>> As a result we are a step closer toward splitting the code into a
>>> separate
>>> library. It's highlighted some of the WCCPv2 issues and a pathway
>>> forward
>>> now clear:
>>> - move types definitions to a protocol types header (wccp2_types.h ?)
>>> - correct mangled definitions for generic use. including code in that.
>>> - add capability handling
>>> - add hash/mask service negotiation
>>> - add sibling peer discovery through WCCP group details ??
>>>
>>>
>>> Amos
>>> --
>>> Please be using
>>> Current Stable Squid 2.7.STABLE5 or 3.0.STABLE11
>>> Current Beta Squid 3.1.0.3
>>>
>
>

-- 
Please be using
   Current Stable Squid 2.7.STABLE5 or 3.0.STABLE11
   Current Beta Squid 3.1.0.3