Re: Request for new round of SBuf review

On Sun, 2008-12-07 at 21:26 +0100, Kinkie wrote:

> Not much new code yet, but as a result of our discussion there's a
> small adjustmdent in strategy, which in the short term has two parts:
> the code I posted is valid and I still wish it to be reviewed. SBuf 's
> purpose changes as it'll aim at catering the need to handle blobs
> I've set off writing StringNg which uses a Sbuf as storage and
> reexports most of its interface, trying to keep track of encodings
> etc.
> In practical terms , Sbuf:.cmpNoCase moves to String.

Hi Kinkie,

    As you know, I consider the Buffer/String split important. I will
wait for that change to be completed before reviewing your code again.
Please post when that part is done and you are comfortable with the
code.

Thank you,

Alex.

> On Sun, Dec 7, 2008 at 5:33 AM, Adrian Chadd <adrian_at_squid-cache.org> wrote:
> > Howdy,
> >
> > As most of you aren't aware, Kinkie, alex and I had a bit of a
> > discussion about this on IRC rather than on the mailing list, so
> > there's probably some other stuff which should be posted here.
> >
> > Kinkie, are you able to post some updated code + docs after our discussion?
> >
> > My main suggestion to Kinkie was to take his code and see how well it
> > worked with some test use cases - the easiest and most relevant one
> > being parsing HTTP requests and building HTTP replies. I think that a
> > few test case implementations outside of the Squid codebase will be
> > helpful in both understanding the issues which this sort of class is
> > trying to solve.
> >
> > I would really be against integrating it into Squid mainline until
> > we've all had a chance to play with it without being burdened by the
> > rest of Squid. :)
> >
> >
> >
> > Adrian
> >
> >
> > 2008/12/4 Kinkie <gkinkie_at_gmail.com>:
> >> Hi all,
> >> I feel that SBuf may just be complete enough to be considered a
> >> viable replacement for SquidString, as a first step towards
> >> integration.
> >> I'd appreciate anyone's help in giving it a check to gather feedback
> >> and suggestions.
> >>
> >> Doxygen documentation for the relevant classes is available at
> >> http://eu.squid-cache.org/~kinkie/sbuf-docs/ , the code is at
> >> lp:~kinkie/squid/stringng
> >> (https://code.launchpad.net/~kinkie/squid/stringng).
> >>
> >> Thanks!
> >>
> >> --
> >> /kinkie
> >>
> >>
> >
>
>
>
Received on Thu Dec 11 2008 - 18:14:17 MST