Re: squid_kerb_auth.c broken in trunk

Markus Moeller wrote:
>
> The existing code in the squid_kerb_auth directory is minimal and has no
> configure. So the config.test wouldn't work.
> The tarball is necessary as it has all the configure files.
>
> Otherwise the absolute minimal test would be:
>
> #!/bin/sh
> # Don't build without gssapi.h
> if [[ -f /usr/include/gssapi/gssapi.h || -f /usr/include/gssapi.h ]]; then
> exit 1
> fi
> exit 0
>
>
> Markus
>

Now thats I'm awake again, yes we will have to go with the minimal.
These tests are run from squid~/configure long before the helper
configure script is created.

Adding it shortly.

Amos

>
> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
> news:490C7C18.4090805_at_treenet.co.nz...
>> Markus Moeller wrote:
>>> Can you use my tar file from sourceforge
>>> http://downloads.sourceforge.net/squidkerbauth/squid_kerb_auth-1.0.3.tar.gz
>>> with the following config.test ?
>>>
>>> #!/bin/sh
>>> # Don't build if configure fails
>>> ./configure "$@"
>>> if [ $? == 0 ]; then
>>> exit 1
>>> fi
>>> exit 0
>>>
>>> Markus
>>>
>>
>> I'll have to try this in the morning.
>>
>> Meanwhile, is there other new code to import from the tarball or can I
>> just paste the config.test into place?
>>
>> Amos
>>
>>> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
>>> news:490C5E0D.3070307_at_treenet.co.nz...
>>>> Markus Moeller wrote:
>>>>> Is there something I can do ?
>>>>>
>>>>> Markus
>>>>>
>>>>
>>>> You can write the config.test script if you know portable shell script.
>>>> You are also likely the one who knows best what tests are critical
>>>> for the helper to run.
>>>>
>>>> A series of if like this:
>>>>
>>>> if test -f /usr/include/gssapi.h ; then exit 0; fi
>>>> ...
>>>> exit 1
>>>>
>>>> is sort of whats needed. I know, its nasty and duplicates the
>>>> smarter logic in configure.
>>>>
>>>> Amos
>>>>
>>>>> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
>>>>> news:490BBA7D.6020005_at_treenet.co.nz...
>>>>>> Markus Moeller wrote:
>>>>>>> As far as I remember, with these options squid_kerb_auth
>>>>>>> shouldn't be included in the build.
>>>>>>
>>>>>> Default is for all helpers to build unless an explicit set is chosen.
>>>>>>
>>>>>> We run a $helper/config.test /bin/sh script to test whether a
>>>>>> helper should be automatically disabled. This is a NOP in the kerb
>>>>>> auth helper at present.
>>>>>> Sounds like it needs to be made to perform some tests for stuff
>>>>>> like gssapi.
>>>>>>
>>>>>> Amos
>>>>>>
>>>>>>>
>>>>>>> Markus
>>>>>>>
>>>>>>> "Alex Rousskov" <rousskov_at_measurement-factory.com> wrote in
>>>>>>> message news:1225397539.6256.296.camel_at_pail...
>>>>>>>> On Thu, 2008-10-30 at 20:01 +0100, Henrik Nordstrom wrote:
>>>>>>>>> On tor, 2008-10-30 at 10:49 -0600, Alex Rousskov wrote:
>>>>>>>>>
>>>>>>>>> > I do not have gssapi.h and it should not be required to build
>>>>>>>>> Squid > with
>>>>>>>>> > my configure options. Sorry for not being explicit: I need
>>>>>>>>> the > trunk
>>>>>>>>> > code to build cleanly. I do not care if the, hopefully, optional
>>>>>>>>> > squid_kerb_auth is built.
>>>>>>>>>
>>>>>>>>> What configure options did you use?
>>>>>>>>
>>>>>>>>> > > Configure options are:
>>>>>>>>> > >
>>>>>>>>> > >> --enable-icap-client \
>>>>>>>>> > >> --enable-ecap \
>>>>>>>>> > >> --enable-ssl \
>>>>>>>>> > >> --disable-optimizations \
>>>>>>>>
>>>>>>>> Alex.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Please be using
>>>>>> Current Stable Squid 2.7.STABLE5 or 3.0.STABLE10
>>>>>> Current Beta Squid 3.1.0.1
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Please be using
>>>> Current Stable Squid 2.7.STABLE5 or 3.0.STABLE10
>>>> Current Beta Squid 3.1.0.1
>>>>
>>>
>>>
>>
>>
>> --
>> Please be using
>> Current Stable Squid 2.7.STABLE5 or 3.0.STABLE10
>> Current Beta Squid 3.1.0.1
>>
>
>

-- 
Please be using
   Current Stable Squid 2.7.STABLE5 or 3.0.STABLE10
   Current Beta Squid 3.1.0.1