Re: /bzr/squid3/trunk/ r9270: Properly fix squid_kerb_auth configure recursion

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Thu, 09 Oct 2008 22:19:31 +1300

Henrik Nordstrom wrote:
> On tor, 2008-10-09 at 16:01 +1300, Amos Jeffries wrote:
>>> ------------------------------------------------------------
>>> revno: 9270
>>> committer: Henrik Nordstrom <henrik_at_henriknordstrom.net>
>>> branch nick: trunk
>>> timestamp: Thu 2008-10-09 00:39:31 +0200
>>> message:
>>> Properly fix squid_kerb_auth configure recursion
>>> modified:
>>> configure.in
>>>
>> This isn't exactly a fix though is it?
>
> It is. AC_CONFIG_SUBDIR wasn't called at all depending on how the helper
> was selected.

.. Doh. I overlooked the offset difference in your fix. Thanks.

>
>> I'd like to get a custom macro which does all this looping and detection
>> for helpers in the general case. That should cut out quite a few dozen
>> lines from configure.in.
>
> Agreed. But not scilled enough in M4 to write such macro..
>
> Note: AC_CONFIG_SUBDIR needs to be called with explicit path, not shell
> variables.

I found that the hard way when I tried adding it for general case on the
first fix attempt.

Amos

-- 
Please use Squid 2.7.STABLE4 or 3.0.STABLE9
Received on Thu Oct 09 2008 - 09:19:39 MDT

This archive was generated by hypermail 2.2.0 : Thu Oct 09 2008 - 12:00:03 MDT