Re: [MERGE] Connection pinning patch

Its a 900-odd line patch; granted, a lot of it is boiler plate for
config parsing and management, but I recall the issues connection
pinning had when it was introduced and I'd hate to try and be the one
debugging whatever crazy stuff pops up in 3.1 combined with the
changes to the workflow connection pinning introduces.

I don't pretend to completely understand the implications for ICAP
either. Is there any documentation for how connection pinning should
behave with ICAP and friends?

Is there any particular rush to get this in for this release at such a
late point in the release cycle?

Could we hold off of it until the next release, and just focus on
getting whats currently in 3.HEAD released and stable?

Adrian

2008/9/21 Tsantilas Christos <chtsanti_at_users.sourceforge.net>:
> Hi all,
>
> This patch fixes the bug 1632
> (http://www.squid-cache.org/bugs/show_bug.cgi?id=1632)
> It is based on the original squid2.5 connection pinning patch developed by
> Henrik (http://devel.squid-cache.org/projects.html#pinning) and the related
> squid 2.6 connection pinning code.
>
> Although I spend many hours looking on pined connections I am still not
> absolutely sure that does not have bugs. However the code is very similar
> with this in squid2.6 (where the pinning code runs for years) and I hope
> will be easy to fix problems and bugs.
>
> Regards,
> Christos
>
Received on Sun Sep 21 2008 - 16:07:09 MDT