Re: SBuf review

On Fri, 2008-09-19 at 13:08 +0800, Adrian Chadd wrote:

> I'll say it again - ignore MemBuf. Ignore MemBuf for now. Leave it as
> a NUL-terminated dynamic buffer with some printf append like
> semantics.
>
> When you've implemented a non-NUL-terminated ref-counted memory region
> implementation and you layer some basic strings semantics on top of
> it, you can slowly convert or eliminate the bulk of the MemBuf users
> over.
>
> You're going to find plenty of places where the string handling is
> plain old horrible. Don't try to cater for those situations with
> things like "NULL strings". I tried that, its ugly. Aim to implement
> something which'll cater to something narrow to begin with - like
> parsing HTTP headers - and look to -rewrite- larger parts of the code
> later on. Don't try to invent things which will somehow seamlessly fit
> into the existing code and provide the same semantics. Some of said
> semantics is plain shit.

+1 (again)

Alex.
Received on Fri Sep 19 2008 - 14:38:56 MDT