Re: /bzr/squid3/trunk/ r9190: Build Errors

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Mon, 15 Sep 2008 00:23:26 +1200

Henrik Nordstrom wrote:
> On sön, 2008-09-14 at 12:27 +0200, Guido Serassio wrote:
>
>>> -CFLAGS="-DDEFAULT_SQUID_DATA_DIR=\"$datadir\" $CFLAGS"
>>> +CFLAGS="-DDEFAULT_SQUID_DATA_DIR=\\\"$datadir\\\" $CFLAGS"
>
>> Currently I don't have time to try, but I'm not sure of what will
>> happen on Windows after this change.
>
>> If I'm understanding right, the path will be arranged as /C:/squid/.
>
> No. The changes is in shell quoting to properly handle whitespace, not
> the path as such.

Both wrong.

The fix is in shell, but it is to correctly pass the " down through two
levels (automake and make command lines) without losing it.

There should be (and is for me now) a \" arriving on the compiler
command line, so the macro define is identified as a char* string properly.

Amos

-- 
Please use Squid 2.7.STABLE4 or 3.0.STABLE9
Received on Sun Sep 14 2008 - 12:23:38 MDT

This archive was generated by hypermail 2.2.0 : Sun Sep 14 2008 - 12:00:04 MDT