Re: astyle

Tsantilas Christos wrote:
> Hi Amos,
> I had post the latest version of the formatter (plus a small script
> for checking md5 signatures):
> http://www.mail-archive.com/squid-dev@squid-cache.org/msg07208.html
>
> In all test I run, worked without problems.
> I think it is OK.
> Regards,
> Christos
>

Finally got around to running it myself on just src/*.*

For me md5checker detects bungled files. I haven't looked further than
those files to see if other directories are bunged as well.

md5checker.sh assures us the printable byte order is identical, yes?

access_log.cc - converts the prepared array of log format tokens
                removing the \n placed to make the list human readable.

This is a big issue. The array entries which are properly documented
show up worst.

gopher.cc - I couldn't find it. But the diff itself could hide a lot.
Some fairly large chunks of code being shifted left by astyle and get
fully shuffled by a diff.

Of the rest all I could see was comments being shifted inside { . which
is okay.

   dnsserver.cc
   HttpHdrRange.cc
   snmp_agent.cc

Amos

-- 
Please use Squid 2.7.STABLE4 or 3.0.STABLE9