Re: [MERGE] WCCPv2 Config Cleanup

Adrian Chadd wrote:
> Amos, why are you pushing through changes to the WCCP configuration
> stuff at this point in the game?

All the magic numbers in the squid.conf have been bugging me for a
while. There seems to have been a renewed interest in getting WCCP
configs right since Tproxy v4 stuff went in that uses it.

This one was easy and isolated, so I went and did it early.
It's back-compatible, so people don't have to use the new names if they
like. But its clearer for the newbies until the big cleanup you mention
below is stable.

>
> The WCCPv2 stuff works fine (for what it does); it could do with some
> better documentation but what it really needs is to be broken out from
> Squid itself and run as a seperate daemon.
>

I've been waiting most of a year for your work on that direction in
Squid-2 to be ported over. There does not appear to be any sign of it
happening in time for 3.1.
The rest of us are largely concentrating on cleaning other components.

>
> Adrian
>
> 2008/9/13 Henrik Nordstrom <henrik_at_henriknordstrom.net>:
>> With the patch the code uses WCCP2_METHOD_.. in some places (config
>> parsing/dumping) and the context specific ones in other places. This is
>> even more confusing.
>>
>> Very minor detail in any case.
>>
>>
>> On lör, 2008-09-13 at 09:49 +0800, Adrian Chadd wrote:
>>> The specification defines them as separate entities and using them in
>>> this fashion makes it clearer for people working on the code.
>>>
>>>
>>>
>>> Adrian
>>>
>>> 2008/9/13 Henrik Nordstrom <henrik_at_henriknordstrom.net>:
>>>> On fre, 2008-09-12 at 20:39 +1200, Amos Jeffries wrote:
>>>>
>>>>> +#define WCCP2_FORWARDING_METHOD_GRE WCCP2_METHOD_GRE
>>>>> +#define WCCP2_FORWARDING_METHOD_L2 WCCP2_METHOD_L2
>>>>> +#define WCCP2_PACKET_RETURN_METHOD_GRE WCCP2_METHOD_GRE
>>>>> +#define WCCP2_PACKET_RETURN_METHOD_L2 WCCP2_METHOD_L2
>>>> Do we still need these? Why not use WCCP2_METHOD_ everywhere if ther are
>>>> the same value?
>>>>
>>>> Regards
>>>> Henrik
>>>>
>>>>
>>

-- 
Please use Squid 2.7.STABLE4 or 3.0.STABLE8