Re: [RFC] COSS removal from 3.0

On Fri, 2008-09-05 at 23:12 +1200, Amos Jeffries wrote:
> > On Fri, 2008-09-05 at 01:46 +1200, Amos Jeffries wrote:
> >> I'm expecting to roll 3.0.STABLE9 sometime over the next 5 days.
> >>
> >> One update still to be done is the removal of COSS.
> >>
> >> I had planned on just dead-coding (disabling) it. But with the configure
> >> recursion being dynamic thats not easily possible.
> >>
> >> I'm currently considering dropping an #error abortion into the top of
> >> all COSS code files to kill any builds trying to use it. Anyone have a
> >> better way? drop the code entirely from 3.0?
> >
> > I would recommend against changing source files -- it will make porting
> > Squid2 (or Squid v3.1) fixes harder. I would leave everything "as is"
> > but add a ./configure warning if coss is being enabled. Would that work?
>
> #error is a one-liner and does not affect patching.
> #if 0 / dead-codng would be a two-liner with the same non-affect.
>
> I went for a configure fix first thing, there are at least two dynamic
> loops where we would have to add the sub-string test and warning message.
> Seems to me more work than its worth to do and test such a configure
> update.

Understood. I have no strong objections to the disabling method you
prefer.

Thank you,

Alex.
Received on Fri Sep 05 2008 - 15:07:11 MDT