Re: [MERGE] Rework urlAbsolute to be a little more streamlined.

From: Benno Rice <benno_at_jeamland.net>
Date: Mon, 1 Sep 2008 13:30:16 +1000

On 01/09/2008, at 1:01 PM, Amos Jeffries wrote:

>> Resubmit this patch, including changes based on comments by various
>> people.
>>
>> - Mention RFC text in relation to changing the default behaviour in
>> relation
>> to unknown HTTP methods.
>> - Use safe_free instead of xfree.
>> - Rework urlAbsolute to use snprintf in a slightly better way.
>> Snprintf
>> is now
>> used to construct the initial portion of the url and the rest is
>> added
>> on
>> using POSIX string routines.
>>
>
> I'm sure you can still crop the xstrdup() usage by adding a JIT
> allocation
> of urlbuf before "if (req->protocol == PROTO_URN)"
> and returning urlbuf plain at the end.

As in malloc it?

-- 
Benno Rice
benno_at_jeamland.net
Received on Mon Sep 01 2008 - 03:30:41 MDT

This archive was generated by hypermail 2.2.0 : Mon Sep 01 2008 - 12:00:06 MDT