Re: Making start/stop idempotent

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 12 Aug 2008 18:02:12 +1200 (NZST)

> Our management tools like processes to be idempotent; i.e., you should
> be able to start or stop a process any number of times without it
> throwing an error.
>
> Currently, Squid will return 1 if a squid process is already running
> (upon start) and when there isn't one (upon -k shutdown).
>
> I'm writing a patch to change this behaviour, and the most reasonable
> way to do it seems to be with a command-line option; I've somewhat
> arbitrarily chosen -p.
>
> Does this seem reasonable? If so, I'll submit a patch shortly.
>

I agree with Robert. The behavior change is nice. Requiring another option
to enable/disable it is not.

I'd personally go with just the behavior change to the HEAD trees.
Only disabling and adding the option to enable if its ported to currently
stable releases (2.7, 3.0).

Amos
Received on Tue Aug 12 2008 - 06:02:15 MDT

This archive was generated by hypermail 2.2.0 : Tue Aug 12 2008 - 12:00:04 MDT