Re: Announcing branch: cachemgr-refactoring

Amos Jeffries wrote:
> Kinkie wrote:
>> Hi all.
>> I'm currently poking around cachemgr to try and finish converting it
>> to c++.
>> Anyone willing to spend some time laughing at my mistakes (and
>> hopefully suggest how to fix them) can do so by checking out the
>> branch at http://www.squid-cache.org/~kinkie/bzr/cachemgr-refactor
>>
>
> Which side of cachemgr have you been refactoring? cachemgr.cgi,
> squidclient, or the internal component?
>
> Amos

I finally managed to get the branch to download.

I've only had a brief look at the additions, but here's my 2 cents on
style so far:

  - You may want to use HERE macro in the debugs lines so they get all
the location debug info on lines displayed.

  - You probably should use DGB_CRITICAL instead of debugs(N,0,...
     likewise DBG_IMPORTANT for debugs(N,1,...

I know its not your change but, on the patch diff, I spotted: debug(16,
0) ("Reconfigure by command.\n"); which will need to be fixed to debugs().

  - Why are there two identical "Shutdown by command" methods in two
different objects?

Amos

-- 
Please use Squid 2.7.STABLE3 or 3.0.STABLE7