Re: [MERGE-3.0] Support large response headers

sön 2008-04-06 klockan 18:39 -0600 skrev Alex Rousskov:
> That's comforting. Do any bigger-than-usual headers end up being sent to
> ICAP after your patch is applied?

Yes, that may happen in trunk already, but it later gets confused in
client_side_reply.cc without the last submission.

In 3.0 we have
- Response dataflow hangs indefinitely if response line + headers > 4KB.

In trunk
- Transaction abruptly aborted when reaching client_side_reply.cc.
(connection closed, no error message outside cache.log)

Additionally, if there turns out to be a problem one may set
reply_header_max_size to limit the accepted header size, making Squid
abort the transaction gracefully. (does not work in 3.0 without at least
the first part of the change).

> > I propose we commit the change to trunk, and run verifications there. If
> > it doesn't break things verify the 3.0 version and commit that.
>
> Sounds good to me.

Done.

Regards
Henrik
Received on Mon Apr 07 2008 - 01:39:18 MDT