Re: $(SHELL) for test-suite/testheaders.sh

From: Amos Jeffries <squid3@dont-contact.us>
Date: Sun, 06 Apr 2008 00:40:38 +1300

Alex Rousskov wrote:
> Amos,
>
> Could you please change Makefile.ams so that
> test-suite/testheaders.sh is executed using $(SHELL)? For example,
>
> $(SHELL) $(top_srcdir)/test-suite/testheaders.sh ...
>
> There may be a better, automake-assisted way of running shell scripts,
> but I do not know it.
>
> Without SHELL or equivalent, if bash is not installed in /bin/, the user
> of "make check" gets an error:
>
>
>> gmake[2]: Entering directory `/home/rousskov/Edit/squid3/ecap/lib'
>> gmake testHeaders tests/testAll
>> gmake[3]: Entering directory `/home/rousskov/Edit/squid3/ecap/lib'
>> ../test-suite/testheaders.sh "g++ -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -I/usr/local/include -Werror -Wall -Wpointer-arith -Wwrite-strings -Wcomments -g " "../include" || exit 1
>> /usr/local/bin/bash: ../test-suite/testheaders.sh: /usr/bin/bash: bad interpreter: No such file or directory
>> gmake[3]: *** [testHeaders] Error 1
>
> It would be nice to have the name of the testheaders.sh script as a
> Makefile.am variable (perhaps even stored in one common.am file which is
> included by all Makefiles), but that can wait.
>

Done.

I dream of it really being completely recursive and only run from one
Makefile.am . But today the per-directory compiler options are still
getting in the way. Maybe after the great library changes it will be
possible.

Amos

-- 
Please use Squid 2.6.STABLE19 or 3.0.STABLE4
Received on Sat Apr 05 2008 - 05:40:25 MDT

This archive was generated by hypermail 2.2.0 : Wed Apr 30 2008 - 12:00:07 MDT