Re: /bzr/squid3/trunk/ r8912: Attempted fix for FreeBSD run-time socket error "(22) Invalid Object" on connects

Alex Rousskov wrote:
> On Thu, 2008-04-03 at 08:56 -0600, Alex Rousskov wrote:
>
>> I am not sure at all, but it feels like you are missing some #includes
>> in the test cases.
>

Ah thanks for that. I've added it to configure.

I've also rolled the specific comm_connect_addr parts out so trunk will
run again until it can be tested more thoroughly. The rest is
essentially unused code now but its unused code that needs to be tested
and used.

For Adrian and others doing Linux testing may want to use this patch to
re-insert it:
http://treenet.co.nz/prjects/squid/patches/linux-leak_comm_connect_addr.patch

I'll see if one of the offers of FreeBSD test boxes are still open. I
don't think I can or want to exactly run a live proxy on squid-cache.org
itself.

Amos

> Adding #include <netinet/in.h> to test cases would give you:
>
>> configure:23105: checking for ss_len field in struct sockaddr_storage
>> configure:23159: result: yes
>> configure:23175: checking for sin_len field in struct sockaddr_in
>> configure:23229: result: yes
>> configure:23245: checking for sin6_len field in struct sockaddr_in6
>> configure:23299: result: yes
>
> but the problem remains even with those fixed ./configure results:
>
>> 2008/04/03 09:57:59.122| ConnectSateData::connect: to 10.0.0.104:1344
>> 2008/04/03 09:57:59.122| comm_connect_addr: connecting socket 8 to 10.0.0.104:1344 (want family: 2)
>> 2008/04/03 09:57:59.122| comm_connect_addr: sock=8, addrinfo( , family=2, addrlen=128 )
>> 2008/04/03 09:57:59.122| connect FD 8: (-1) (22) Invalid argument
>> 2008/04/03 09:57:59.122| connecting to: 10.0.0.104:1344
>> 2008/04/03 09:57:59.122| ConnectStateData::connect: FD 8: * - try again
>> 2008/04/03 09:57:59.122| ConnectStateData::connect: FD 8: * - ERR tried too many times already.
>> 2008/04/03 09:57:59.122| commConnectCallback: FD 8
>
> HTH,
>
> Alex.
>
>

-- 
Please use Squid 2.6.STABLE19 or 3.0.STABLE4