Re: two xasserts in squid3

From: Alex Rousskov <rousskov@dont-contact.us>
Date: Mon, 11 Feb 2008 08:04:44 -0700

On Sun, 2008-02-10 at 20:51 +0200, Tsantilas Christos wrote:
> Maybe it was better if the files lib/assert.c and include/assert.h
> removed and the assert macro defined in squid.h file like squid2.6
> does...

It looks like Array, MemPool, and splay files are using assert outside
of src/ so you will not be able to remove include/assert.h. However, you
may be able to declare xassert in include/assert.h while defining it in
src/Debug.cc.

The assert #define in src/Debug.h should probably be moved to
include/assert.h. These #defines must be the same.

When we get a better VCS, we should discuss moving include/ and lib/
stuff into src/ with the exception of 3rd party code. This would avoid
problems created by that artificial boundary.

Alex.
Received on Mon Feb 11 2008 - 08:04:58 MST

This archive was generated by hypermail pre-2.1.9 : Sat Mar 01 2008 - 12:00:09 MST