Re: squid-3.HEAD IPAddress leak

From: Adrian Chadd <adrian@dont-contact.us>
Date: Thu, 7 Feb 2008 11:56:10 +0900

On Thu, Feb 07, 2008, Amos Jeffries wrote:
> > Amos, could you please poke the leak in IPAddress:GetAddrInfo a little?
>
> I'll give it another try. But don't hold your breath too long on that one.
>
> Did you see my note on it?
> I tracked that leak backwards from two segfaults to the connect() system
> call. Then I tracked the allocation from my init forwards to the connect()
> call.
>
> As far as I can tell when connect() returns OK, things work. But if
> connect() fails in any way the addrinfo pointer is immediately pointing
> somewhere in the system read-only memory with a leak lost. Kernel
> segfaults squid when it attempt to cleanup anywhere in the read-only
> areas.

Argh, this temporary malloc/free pair is peppered throughout the codebase!
Grr.

I've removed that hack, and things work fine for me. Ubuntu 7.01 here, x86_64.

Adrian
Received on Wed Feb 06 2008 - 19:44:23 MST

This archive was generated by hypermail pre-2.1.9 : Sat Mar 01 2008 - 12:00:09 MST