Re: 3-HEAD IPv6 updates

>
>
>
>
> On 16/12/2007 2:28 PM, Henrik Nordstrom wrote:
>> On sön, 2007-12-16 at 14:10 +1100, Reuben Farrelly wrote:
>>> Still as of now failing to compile -HEAD for me:
>>
>>> clientInterpretRequestHeaders(ClientHttpRequest*)':
>>> client_side_request.cc:733: error: 'no_addr' was not declared in this
>>> scope
>>> client_side_request.cc:739: error: 'no_addr' was not declared in this
>>> scope
>>> make[3]: *** [client_side_request.o] Error 1
>>> make[3]: Leaving directory `/usr/src/squid/squid-HEAD/src'
>>
>> That's from --enable-useragent-log and --enable-referer-log. We should
>> probably drop those two as the custom log formats accomplish pretty much
>> the same thing..

For now I've converted that code over, and marked your comment in as a note.

>>
>> Regards
>> Henrik
>
> I've removed those options now and getting a bit further.
>
> Using (from config.log):
>
> ./configure --prefix=/usr --host=x86_64-pc-linux-gnu
> --mandir=/usr/share/man
> --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc/squid
> --localstatedir=/var/lib --sysconfdir=/etc/squid
> --libexecdir=/usr/libexec/squid
> --localstatedir=/var --datadir=/usr/share/squid --with-default-user=squid
> --enable-auth=basic,digest,negotiate,ntlm
> --enable-removal-policies=lru,heap
> --enable-digest-auth-helpers=password
> --enable-basic-auth-helpers=SASL,PAM,SMB,multi-domain-NTLM,getpwnam,NCSA,MSNT
> --enable-external-acl-helpers=wbinfo_group,ip_user,session,unix_group
> --enable-ntlm-auth-helpers=SMB,fakeauth --enable-cache-digests
> --enable-delay-pools --enable-arp-acl --with-large-files --enable-snmp
> --enable-ssl --enable-storeio=ufs,diskd,coss,aufs,null
> --enable-linux-netfilter
> --libdir=/usr/lib64 --build=x86_64-pc-linux-gnu
> --enable-cachemgr-hostname=tornado.reub.net --enable-icap-client
>
> Bailing out on this:
>
> make[3]: Entering directory `/usr/src/squid/squid-HEAD/src'
> depbase=`echo peer_digest.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; \
> if x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H
> -DDEFAULT_CONFIG_FILE=\"/etc/squid/squid.conf\" -I. -I. -I../include -I.
> -I.
> -I../include -I../include -I../lib/libTrie/include
> -I/usr/include/libxml2
> -Werror -Wall -Wpointer-arith -Wwrite-strings -Wcomments -D_REENTRANT
> -m64 -O0
> -g -pipe -march=native -mtune=native -MT peer_digest.o -MD -MP -MF
> "$depbase.Tpo" -c -o peer_digest.o peer_digest.cc; \
> then mv -f "$depbase.Tpo" "$depbase.Po"; else rm -f
> "$depbase.Tpo";
> exit 1; fi
> cc1plus: warnings being treated as errors
> peer_digest.cc: In function 'void peerDigestCheck(void*)':
> peer_digest.cc:260: warning: unused variable 'buf'
> make[3]: *** [peer_digest.o] Error 1
> make[3]: Leaving directory `/usr/src/squid/squid-HEAD/src'

Hmm, weird this got past the testing. killed.

>
> If I disable peer-digests I now get this:
>
> make[3]: Entering directory `/usr/src/squid/squid-HEAD/src'
> depbase=`echo ACLARP.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; \
> if x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H
> -DDEFAULT_CONFIG_FILE=\"/etc/squid/squid.conf\" -I. -I. -I../include -I.
> -I.
> -I../include -I../include -I../lib/libTrie/include
> -I/usr/include/libxml2
> -Werror -Wall -Wpointer-arith -Wwrite-strings -Wcomments -D_REENTRANT
> -m64 -O0
> -g -pipe -march=native -mtune=native -MT ACLARP.o -MD -MP -MF
> "$depbase.Tpo" -c
> -o ACLARP.o ACLARP.cc; \
> then mv -f "$depbase.Tpo" "$depbase.Po"; else rm -f
> "$depbase.Tpo";
> exit 1; fi
> ACLARP.cc: In function 'int aclMatchArp(SplayNode<acl_arp_data*>**,
> IPAddress&)':
> ACLARP.cc:277: error: no matching function for call to
> IPAddress::GetSockAddr(sockaddr&)'
> ../include/IPAddress.h:362: note: candidates are: void
> IPAddress::GetSockAddr(sockaddr_in&) const
> ACLARP.cc:339: error: no matching function for call to
> 'IPAddress::GetSockAddr(sockaddr&)'
> ../include/IPAddress.h:362: note: candidates are: void
> IPAddress::GetSockAddr(sockaddr_in&) const
> cc1plus: warnings being treated as errors
> ACLARP.cc:245: warning: unused variable 'ntoabuf'
> make[3]: *** [ACLARP.o]

OK, I've patched a bit to make this go through.
It's making the assumption that ARP actually uses a sockaddr_in where the
arp_req data struct uses sockaddr. Not a good assumption, bit little I can
do beyond trusting the people who created sockaddr_in got it right for
this case.

>
> Disable --enable-arp-acl and the make continues through to completion.
>
> Reuben
>
>
Received on Sun Dec 16 2007 - 15:32:38 MST