Re: BodyPipe size_t / uint64_t

On Mon, 1 Oct 2007, Henrik Nordstrom wrote:

> On sön, 2007-09-30 at 16:22 -0600, Alex Rousskov wrote:
>
>> BTW, why not make every size-related variable a signed or unsigned
>> int64_t? Is this a performance optimization issue?
>
> To mainly to get a separation when something refers to in-memory data or
> external data.
>
> It's clearer in Squid-2 where squid_off_t is used for object
> sizes/offsets, and size_t / ssize_t for in-memory operations, similarly
> to how off_t is used for file I/O in the standard C API.
>
> I think doing so would make more sense to Squid-3 too. But it's not
> strictly needed as object sizes/offsets is always 64-bits in Squid-3 so
> it was not done. Using a squid_off_t type do help to avoid thoughts
> about if int64_t or uint64_t should be used.

We should do that, eventually. Before we forget, can you file a
corresponding bug/enhancement report, please? I do not have convenient
web access after running portupgrade :-(.

Thank you,

Alex.
Received on Mon Oct 01 2007 - 13:29:08 MDT