Re: cvs commit: squid3/src ftp.cc

On Wed, 2007-08-15 at 09:28 +1200, Amos Jeffries wrote:
> > On Tue, 2007-08-14 at 17:58 +0200, Henrik Nordstrom wrote:
> >> On tis, 2007-08-14 at 23:01 +1200, Amos Jeffries wrote:
> >> > Alex Rousskov wrote:
> >> > > On Mon, 2007-08-13 at 12:01 +0200, Guido Serassio wrote:
> >> > >
> >> > >> Now fixed.
> >> > >
> >> > > If you have time, it may be better to replace a virtual
> >> > > FtpStateData::haveControlChannel(char*) into a static
> >> > > FtpStateData::HaveControlChannel(FtpStateData*, char*) and let it
> >> check
> >> > > the ftpState pointer itself. This will avoid more code repetition
> >> and
> >> > > may even work faster.
> >> >
> >> > Whats with the uppercasing? the method is not a type. Is this a new
> >> > convention not mentioned in the wiki/devel-faq?
> >>
> >> Hmm.. it should be in the style guide somewhere.
> >
> > http://www.squid-cache.org/Devel/squid-3-style.txt
> >
>
> What I based the following on. Alex posted an upper-cased
> internal-but-public method (NOT data member).

The style example and its description are not in sync. The verbal
description should say something like:

  - Global names, including static class members are capitalized.

which would include static class methods like the Instance method in the
style example or the FtpStateData::HaveControlChannel in my suggestions.

HTH,

Alex.
Received on Tue Aug 14 2007 - 15:37:07 MDT