Re: bug 2000 - patch

Robert Collins wrote:
> On Sun, 2007-08-05 at 19:39 +1200, Amos Jeffries wrote:
>> Here is the patch to obsolete StoreEntryStream from squid.
>> If any of you want to check it before I push it to HEAD next weekend.
>>
>> It blocks out the StoreEntryStream class code and test cases, and
>> replaces all use of the stream with calls to storeAppendPrintf().
>>
>> I'm not sure if it needs a Changelog entry since this is code new to 3.0
>> anyway.
>
> So why is this being removed?
>

Building on recent testing versions of Debian with upcoming g++ 4.1.3
and 4.2.1 it fails the unit-tests.

std::setw() on a string/char requires something that is not implemented
in the StoreEntrystream* classes. My limited-knowledge tests haven't
located exactly what it needs to be implemented now for it to work.

The alternative to restore the builds, is to pull the MemObject stats
display (only place the stream is ever actually used) back inline with
the rest of squid to use storeEntryAppendPrintf(). And drop the stream
until someone who knows what needs to be fixed can do so.

Amos
Received on Sun Aug 05 2007 - 04:03:52 MDT