Re: Removing cppunit

On Fri, 2007-04-13 at 13:27 +1200, squid3@treenet.co.nz wrote:
> > On Fri, 2007-04-13 at 12:45 +1200, squid3@treenet.co.nz wrote:
> >>
> >> It has not been linked to the cppunit testers, but I have written a
> >> specific test app to check each function and proivide for maula-eye
> >> check
> >> in increments from simplest up for both ipv4-pure then dual protocol
> >> paths.
> >> Then it has spent nearly a month in live run tests within squid and
> >> manual
> >> debug traces.
> >>
> >> That said, if anyone can think of any asserts that should be in there,
> >> point them out.
> >
> > If the test logic is not hooked into 'make check', then it will not be
> > run regularly. Platform changes or subsequent untested changes to the
> > code base can introduce regressions.
> >
> > I think it should most definately be hooked into the cppunit test suite.
> >
>
> Um, which brings me to ...
>
> Alex: didn't you ask for cppunit to be removed from squid3? if not, I need
> a kick in the right direction on that.

My understanding is that we want to remove cppunit (the program,
framework, or whatever it is) itself but leave Squid-specific test
cases. Somebody will need to install cppunit to actually use Squid test
cases.

This is similar to any other third party tool like GCC or valgrind. We
do not distribute those with Squid, but have things that work with them.

Running "make check" (or whatever it is) would run cppunit test cases if
somebody has cppunit installed and should skip them (with a warning) if
somebody does not have cppunit installed.

If there is a special make target to force running cppunit test cases,
that target will fail if there is no cppunit installed.

HTH,

Alex.
Received on Thu Apr 12 2007 - 21:02:02 MDT