Re: cvs commit: squid/src stat.c tools.c

From: Henrik Nordstrom <henrik@dont-contact.us>
Date: Thu, 02 Nov 2006 01:29:46 +0100

ons 2006-11-01 klockan 13:58 -0700 skrev Duane Wessels:

> struct kb_t uses squid_off_t, which might be signed. That means that
> kb_t.kb could overflow and become negative in kb_incr(). If we detect
> that it is negative, add increasing powers of two until the value becomes
> positive again. This should work if squid_off_t is 32 ot 64 bits.

Duane. can you explain the reasoning behind this? Gut feeling is that
this may actually cause more headaches with a counter bouncing around
unpredictable like this.

Did not see any discussion about this either on squid-dev or bugzilla.

Regards
Henrik

Received on Wed Nov 01 2006 - 17:29:50 MST

This archive was generated by hypermail pre-2.1.9 : Wed Nov 29 2006 - 12:00:05 MST