RE: cvs commit: squid/src wccp2.c

Oops, I assumed that because the bug reporter had "applied the patch" it
would compile correctly.

I've now tested and comitted a new version that compiles :)

Steven

> -----Original Message-----
> From: Guido Serassio [mailto:guido.serassio@acmeconsulting.it]
> Sent: Thursday, 26 October 2006 3:15 AM
> To: Squid Developers
> Cc: swilton@squid-cache.org
> Subject: Re: cvs commit: squid/src wccp2.c
>
> Hi Steven,
>
> Il 08.26 24/10/2006 Steven Wilton ha scritto:
> >swilton 2006/10/24 00:26:51 MDT
> >
> > Modified files:
> > src wccp2.c
> > Log:
> > Bug #<a
> >
> href="http://www.squid-cache.org/bugs/show_bug.cgi?id=1790">1790</a>
> > : Crash on wccp2 + mask assignement + standard wccp service
> >
> > The origianl wccp2 mask assignment did not account for the use of
> > the standard
> > wccp service in the mask assignment code.
> >
> > Revision Changes Path
> > 1.27 +4 -4 squid/src/wccp2.c
>
> There is some problem in your patch:
>
> if gcc -DHAVE_CONFIG_H
> -DDEFAULT_CONFIG_FILE=\"/usr/local/squid/etc/squid.conf\" -I. -I.
> -I../include -I. -I. -I../include -I../include -m32
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -g -O2 -D_REENTRANT
> -MT wccp2.o -MD -MP -MF ".deps/wccp2.Tpo" -c -o wccp2.o wccp2.c; \
> then mv -f ".deps/wccp2.Tpo" ".deps/wccp2.Po"; else rm -f
> ".deps/wccp2.Tpo"; exit 1; fi
> wccp2.c: In function `wccp2Init':
> wccp2.c:625: error: `service' undeclared (first use in this function)
> wccp2.c:625: error: (Each undeclared identifier is reported only once
> wccp2.c:625: error: for each function it appears in.)
> wccp2.c: In function `wccp2AssignBuckets':
> wccp2.c:1450: error: `service' undeclared (first use in this function)
> make[3]: *** [wccp2.o] Error 1
> make[3]: Leaving directory `/home/serassio/2.6/src'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/serassio/2.6/src'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/home/serassio/2.6/src'
> make: *** [all-recursive] Error 1
>
> Regards
>
> Guido
>
>
> -
> ========================================================
> Guido Serassio
> Acme Consulting S.r.l. - Microsoft Certified Partner
> Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
> Tel. : +39.011.9530135 Fax. : +39.011.9781115
> Email: guido.serassio@acmeconsulting.it
> WWW: http://www.acmeconsulting.it/
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.408 / Virus Database: 268.13.11/496 - Release
> Date: 24/10/2006
>
>

-- 
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.408 / Virus Database: 268.13.11/497 - Release Date: 25/10/2006