Re: Split out client protocols from protocol_t

> http://www.squid-cache.org/bugs/show_bug.cgi?id=1763 has attached to it
> a split out of the client protocol support from protocol_t.
>
> This is fairly important to folk wanting to write new client protocol
> modules - at the moment they need to perform shotgun surgery all through
> the code base because the protocol gets listed as a protocol_t, which
> also appears in the logic for request forwarding etc etc etc.
>
> The patch is good enough to commit at the moment IMO.

Hi,
  I haven't tested it, but skimming over its contents I had some thoughts
popping out:

Is the allocator stuff intentionally in? (cosmetic issue)
Is it complete? (logTypeIsAHit seems only halfway refactored)
Aren't we losing information by moving the allocator of ClientInfo from
memAllocate to xmalloc?

My 2 EuroCent...

   Kinkie
Received on Sat Sep 09 2006 - 02:17:45 MDT