Cygwin clientKeepaliveNextRequest

From: Henrik Nordstrom <henrik@dont-contact.us>
Date: Tue, 30 May 2006 15:19:27 +0200

Guido,

in clientKeepaliveNextRequest there is a CYGWIN dependency which looks a
bit odd..

        /*
         * CYGWIN has a problem and is blocking on read() requests when there
         * is no data present.
         * This hack may hit performance a little, but it's better than
         * blocking!.
         */
#ifdef _SQUID_CYGWIN_
        commSetSelect(conn->fd, COMM_SELECT_READ, clientReadRequest, conn, 0);
#else
        clientReadRequest(conn->fd, conn); /* Read next request */
#endif

Is this still needed with current cygwin?

The above code looping the call via the select loop may fail if there is
pipelined requests waiting on the connection as these may be sitting in
the read buffer already...

Regards
Henrik

Received on Tue May 30 2006 - 07:19:31 MDT

This archive was generated by hypermail pre-2.1.9 : Thu Jun 01 2006 - 12:00:04 MDT