Re: cvs commit: squid3/src cache_cf.cc

On Fri, 2006-04-28 at 08:34 +1000, Robert Collins wrote:
> On Thu, 2006-04-27 at 19:07 +0000, wessels@squid-cache.org wrote:
> > wessels 2006/04/27 13:07:16 MDT
> >
> > Modified files:
> > src cache_cf.cc
> > Log:
> > bugfix: ICAPConfig calls aclParseAccessLine(), which now takes a
> > ConfigParser argument. Use the LegacyParser from cache_cf.cc, but
> > we need to make it global instead of static.
> >
> > Revision Changes Path
> > 1.492 +2 -2 squid3/src/cache_cf.cc
>
> I'm trying to decouple the parser from the config with the LegacyParser:
> adding the parser as a common parameter to the modular parser like:
>
> aclParseAccessLine(LegacyParser, head);
>
> For example in cache_cf.cc:
>
> static void
> parse_icap_service_type(ICAPConfig * cfg)
> {
> cfg->parseICAPService(LegacyParser);
> }
>
>
> Is that OK?

Attached a patch to make it so.

The point of this is to allow testing of configuration using modules
without linking cache_cf.o in - because that drags in all of squid by
reference. Instead the tokeniser only is brought in.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.