Re: refresh.cc question

tor 2006-04-20 klockan 18:27 +1200 skrev Doug Dixon:

> I've dug in the code and interpreted the if statement as follows: If
> there are no occurrences of reload-into-ims or ignore-reload in any
> refresh_patterns, and reload_into_ims is off, then flags.nocache_hack
> will be false.

Also the request will never get here if it's a reload request.

> But doesn't this code mean that if I've got a reload-into-ims or
> ignore-reload in at least one of my refresh_patterns, but the request
> currently being analysed by this method does NOT have either of these
> flags, (i.e. skips the first two else statements) that it will always
> be force-reloaded?

No, the request only gets this flag set if there if it is a client
forced reload. See where the flag is set in client_side_request.cc.

    if (no_cache) {
#if HTTP_VIOLATIONS

        if (Config.onoff.reload_into_ims)
            request->flags.nocache_hack = 1;
        else if (refresh_nocache_hack)
            request->flags.nocache_hack = 1;
        else
#endif

            request->flags.nocache = 1;
    }

where no_cache is true only if it's a "reload" request (no-cache and a
few other optional hacks.. see the code above the fragment above for
full details..).

Regards
Henrik