Re: Opinion on some open bugs

Hi Henrik,

At 16.45 03/08/2005, Henrik Nordstrom wrote:

>On Tue, 12 Jul 2005, Serassio Guido wrote:
>
>>The problem is clear.
>>But what about a simple workaround like the following patch ?
>>
>>+#ifdef _SQUID_SOLARIS_
>>+#define SOLARIS 1
>>+#undef free
>>+#undef sync
>>+#endif
>>#include <ip_compat.h>
>
>Looks reasonable as a temporary workaround, but the real problem of
>in which order the include files are referenced should be fixed. For
>now add a comment just why this is required and I am fine with it.

Finally I have full understood Solaris problems related to Ipfilter.
There are 3 different problems here:

- free redefinition when using ARP acl with ipfilter, this seems to
affect only Squid 2.5, and the 2.5 workaround patch (just applied)
from Bug #199 fix it.
- gcc fixed/not fixed includes, this seems to affect only Squid 3.0,
and the already applied 3.0 patch from Bug #199 fix it.
- Missing definition of SOLARIS2 when using recent ipfilter versions,
this affect both Squid 2.5 an 3.0, causing all the conflicting errors
from bug #199 and #1374. 3.0 patch is already applied, I'm waiting
for opinions on 2.5 patch before commit.

If you agree, I think that now Bug #199 could be really closed.

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Sun Aug 14 2005 - 15:01:58 MDT