Re: AW: AW: [squid-users] Squid 2.5 Stable 10: warnings

On Tue, 31 May 2005, Rost Werner ZFBE GMT-ISN wrote:

> your hint helped a little bit: I could repair
>
> Array.c
> hash.c
> heap.c
> Stack.c
> util.c
>
> for which the warning are gone.
>
> Because I am not a programmer I can not correct
>
> cf_gen.c:406: warning: cast from pointer to integer of different size
> cf_gen.c:421: warning: cast from pointer to integer of different size
> cf_gen.c:450: warning: cast from pointer to integer of different size
> cf_gen.c:451: warning: cast from pointer to integer of different size
> cf_gen.c:501: warning: cast from pointer to integer of different size
> cf_gen.c:541: warning: cast from pointer to integer of different size
> cf_gen.c:568: warning: cast from pointer to integer of different size
> cf_gen.c:591: warning: cast from pointer to integer of different size
> cf_gen.c:600: warning: cast from pointer to integer of different size
> cf_gen.c:602: warning: cast from pointer to integer of different size

From what I can tell all of these is the same assert error as commented on
before.

   assert(pointer);
should be
   assert(pointer != NULL);

as struct->pointer is still a pointer.

> wb_ntlm_auth.c:90: warning: subscript has type `char'
> wb_ntlm_auth.c:100: warning: subscript has type `char'
> wb_check_group.c:130: warning: subscript has type `char'
> wb_check_group.c:130: warning: subscript has type `char'

Should use xtoupper/xtolower instead of their noraml counterparts without
the x for this specific reason.

> wb_check_group.c:367: warning: int format, different type arg (arg 4)

This one I don't quite get. But I guess it is something in the debug()
macro of this helper. But if it was I would expect a lot of these
warnings when compiling this file.

If you comment out the line (add // first on the line) does the warning
move to the next line using debug()?

Regards
Henrik
Received on Tue May 31 2005 - 11:31:43 MDT