Re: Major pending change in 2.5 for multi-gigabyte file support

On Wed, 30 Mar 2005, Serassio Guido wrote:

> A little cleanup in client.c:
>
> Index: src/client.c
> ===================================================================
> RCS file: /squid/squid/src/client.c,v
> retrieving revision 1.94.2.7
> diff -u -p -r1.94.2.7 client.c
> --- src/client.c 26 Mar 2005 02:50:51 -0000 1.94.2.7
> +++ src/client.c 30 Mar 2005 08:01:37 -0000
> @@ -379,7 +379,7 @@ main(int argc, char *argv[])
> -1.
> 0,
> - (long long) (fsize + 1023) / 1024);
> + (squid_off_t) (fsize + 1023) / 1024);
>
> Windows don't like at all the long long type and fsize is defined as
> squid_off_t type.

This typecast should go away completely, and in addition the printf should
use PRINTF_OFF_T not %lld. A leftover from before squid_off_t was
introduced. Early versions of the patch used off_t and requiring a LFS
build environment.

Fixed.

Regards
Henrik
Received on Wed Mar 30 2005 - 14:15:24 MST