Re: 2.5 and delay pools

On Thu, 4 Mar 2004, Adrian Chadd wrote:

> On Thu, Mar 04, 2004, Adrian Chadd wrote:
>
> > > You need to remove far more fd_set references if this is the problem.
> > > There is also seveal delay pool related fd_set usage in comm_poll, and a
> > > few other places I think.
> >
> > Ok. I must've missed them. Let me go through the codebase and remove
> > all references to fd_set when you're not actually using select().
>
> Ok, the only use I can see is in the slowfds use. The other use of
> fd_set is in the select() codepath.
>
> Here's the patch I'd like to commit:
>

There is also at least the commUpdateReadBits() functions, probably more.

A "quick fix" to detect them all is to add

#if HAVE_POLL
#define fd_set INVALID_USE_OF_FD_SET
#endif

to the end of squid.h.

and then eleminate any errors seen on
 make -C src squid

(assuing make clean)

Regards
Henrik
Received on Thu Mar 04 2004 - 01:01:49 MST