Re: [PATCH] External ACLs sometimes need parameters with spaces in

On Thursday 14 November 2002 17.48, Greg Sheard wrote:

> You did, you're right... I spotted that after I sent mine. I don't
> know which is more correct, although it could be said that \"foo\"
> is 'more standard' (whatever that means nowadays!). I guess we'll
> have to see what the powers that be say about it.

And I have yet another complementary patch to allow for spaces in
"included" files.

My personal opinion is that "Group Name" would have been best, but
unfortunately "" is occupied by the acl "include" function which
should have been `include` (backtick) I think, but is not.. a bit
late to change that one.

There is basically three choices which makes sense I think:

a) Single quotes:
acl group1 external group 'Domain Users'
\ within the quotes is a literal \ ' cannot be used in the value

b) Escaped space characters
acl group2 external group Domain\ Users
Optionally supporting "\ ", "\n", "\r", "\t", '\"', "\octal" and
"\0xHEX".

c) Escaped quote characters
acl group3 external group \"Domain Users\"
Optionally supporting other escapes as above with the exception of \"

In all cases this should be addressed in the strtokFile function,
nowhere else.

My opinion 'a' and 'b' should be supported. I find 'c' confusing. Is
it 'Domain Users', '"Domain' 'Users"' or '"Domain Users"'?

Regards
Henrik
Received on Thu Nov 21 2002 - 12:27:55 MST