Re: using X-Forwarded-For header in access controls

On Thu, 21 Nov 2002, Robert Collins wrote:
> > If so, where do I send the patches?
>
> Here will do, but even better would be to create a development branch on
> devel.squid-cache.org. See that website for what you need to do
> (briefly, join sourceforge, give us the ID number, download and use some
> CVS scripts).

OK. My sourceforge user name is "apbarrett". Please set up the necessary
access permissions.

> > I also have a question about ACLs. If I create an ACL using
> > http->acl_checklist = clientAclChecklistCreate(...), and then follow it
> > using aclNBCheck(...), what is the proper way of cleaning up? I see
> > some existing code simply does http->acl_checklist = NULL, while other
> > existing code uses aclChecklistFree().
>
> It depends on the outcome, or you may have found a memory leak :}. I'd
> need to look in the code to give an authoritative answer. Put it this
> way, if you are leaking, it will show *very quickly* in cachemgr.

Thanks; I'll see if I can find evidence in cachemgr.

--apb (Alan Barrett)
Received on Thu Nov 21 2002 - 09:28:37 MST