RE: winbind authenticator patches

No, they have a problem (checked this with abartlet).

They don't check the return code, only the struct. If the return code is
false, then the result
may very well be senseless garbage. Thus they both have to be checked,
return code first
and result then.
Jerry, could you please rework and resubmit? While the solution is not
perfect, it's obvious that
the current code is faulty.

Thanks

-- 
	ing. Francesco Chemolli
	Unicredit Servizi Informativi
> -----Original Message-----
> From: Henrik Nordstrom [mailto:hno@marasystems.com]
> Sent: Friday, June 28, 2002 9:53 AM
> To: squid-dev@squid-cache.org
> Subject: Fwd: winbind authenticator patches
> 
> 
> should these be applied?
> 
> ----------  Forwarded Message  ----------
> 
> Subject: [squid-users] winbind authenticator patches
> Date: Fri, 28 Jun 2002 03:33:18 -0400
> From: "Jerry Murdock" <jmurdock@itraktech.com>
> To: "Henrik Nordstrom" <hno@marasystems.com>,        "Squid 
> Users" <squid-users@squid-cache.org>
> 
> The attached patches enable the winbind helpers under FreeBSD.
> 
> Tested with the 6/27/2002 2.5 snapshot, FreeBSD 4.6, and Samba 2.2.5.
> 
> Jerry
> 
> -------------------------------------------------------
> 
>