Re: Is this a bug in fs/ufs/store_dir_ufs.c?

Seems you are correct.. should probably be corrected. Not critical
however as the only effect is slightly off removal policy timing for
a extremely tiny subset of your objects on a dirty rebuild.

Regards
Henrik

On Wednesday 01 May 2002 02:55, Yee Man Chan wrote:
> Hi, folks,
>
> I am reading this part of code in 2.4S6. I find
> something that might be a bug. The file is
> fs/ufs/store_dir_ufs.c. The function is question is
> storeUfsRebuildFromSwapLog. It seems to me the first
> line inside the if should be e->lastref = s.lastref
> and the line regarding refcount should be e->refcount
> = s.refcount. I checked HEAD also and it has the same
> thing, too. Can anyone tell me whether this is a bug
> or not? If not, can anyone clarify this for me?
>
> Thanks.
> Yee Man
>
> The code in question:
> --------------
> /* swapfile taken, same URL, newer, update
> meta */
> if (e->store_status == STORE_OK) {
> e->lastref = s.timestamp;
> e->timestamp = s.timestamp;
> e->expires = s.expires;
> e->lastmod = s.lastmod;
> e->flags = s.flags;
> e->refcount += s.refcount;
> storeUfsDirUnrefObj(SD, e);
> } else {
> --------
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Health - your guide to health and wellness
> http://health.yahoo.com
Received on Wed May 01 2002 - 13:34:12 MDT