Re: cvs commit: squid/src MemBuf.c

On Wednesday 17 April 2002 08:29, Adrian Chadd wrote:
> On Tue, Apr 16, 2002, hno@squid-cache.org wrote:
> > hno 2002/04/15 18:35:39 MDT
> >
> > Modified files:
> > src MemBuf.c
> > Log:
> > Have memBufAppend \0 terminate the data, allowing it to be used
> > on strings (done quite frequently, the error was unnotices as
> > mempools always zeroed the data, and the likelyhood the buffer is
> > exacly filled is very small)
>
> Uhm, are you checking to make sure you have enough space in the
> buffer now?

Yes.

http://www.squid-cache.org/cgi-bin/cvsweb.cgi/squid/src/MemBuf.c.diff?r1=1.30&r2=1.31&f=h

Looking at the diff I see that I forgot an paranoid assert.. not sure
I will bother about this one..

Perhaps we should enabled diffs on cvs.squid-cache.org commit
messages?

Regards
Henrik
Received on Wed Apr 17 2002 - 01:58:14 MDT