Re: hno's auth_escape patch

On Thursday 14 February 2002 07.43, Robert Collins wrote:

> I like the url escaping. It's more flexible - in that it allows the
> redirectors and basic auth helpers to use the same interface.
> Digest is already escaped IIRC, and there is that old patch we
> (you?) whipped up for basic.

Only issue I have with URL escaping is that it is escaping. The basic
credentials are not escaped.

If we use URL escaping, then each helper needs to have code for
decoding URL escapes. If we use the Basic credentials as is, then the
only change needed in the helpers are to use : as field separator. A
simple task in all languages.

Note: my posting was a bit unclear. What I meant is to use the
user-pass format of RFC2617, not the raw base64-user-pass header
value.

The redirector interface is different. For one thing it is not
dependent on the auth scheme.

> > Patches for this can be accepted into Squid-2.5 before STABLE
> > unless overly intrusive or delaying the release significantly
> > more. Once STABLE I am afraid we cannot change this until 2.6.
>
> Now is good :].

Agreed.

Regards
Henrik
Received on Thu Feb 14 2002 - 05:30:41 MST