Re: WIN32 GetOSVersion patch

Hi Robert,

Il 10.10 21/10/2001 Robert Collins ha scritto:
>----- Original Message -----
>From: "Guido Serassio" <serassio@libero.it>
>To: "Robert Collins" <robert.collins@itdomain.com.au>
>Cc: <squid-dev@squid-cache.org>
>Sent: Sunday, October 21, 2001 6:03 PM
>Subject: Re: WIN32 GetOSVersion patch
>
>
> > Hi Robert,
> >
> > Il 09.20 21/10/2001 Robert Collins ha scritto:
> > >----- Original Message -----
> > >From: "Guido Serassio" <serassio@libero.it>
> > >To: <squid-dev@squid-cache.org>
> > >Sent: Sunday, October 21, 2001 2:27 AM
> > >Subject: WIN32 GetOSVersion patch
> > >
> > >
> > > > Hi,
> > > >
> > > > This is the first WIN32 patch against HEAD.
> > > >
> > > > This code add support for Windows Me and a better GetOSVersion
> > >function.
> > > >
> > > > Anybody can merge this in HEAD ?
> > > >
> > > > Guido
> > >
> > >Would it make sense to ENUM the _WIN_OS_WIN32S etc defines? I say
>this
> > >because you're apparently able to renumber them...
> >
> > When I write the first version of GetOSVersion, I forgot Windows Me,
>so now
> > I have inserted it renumbering all the NT family defines. I the
>future,
> > because Microsoft has stopped all the 9x development, we will have
>only to
> > add new NT family Windows, without the need of any other defines
> > renumbering (I hope ...).
> >
> > Guido
>
>Sure. The point is that the defines are being used to enumerate the OS
>family. Therefore, we should use an enum rather than defines.
>
>Rob

OK,

There is the changed code.

Guido

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
Tel. : +39.011.610749
E-mail: serassio@interfree.it
         serassio@libero.it
WWW: http://www.serassio.it