Re: lib/rfc2617.c

Actually the rfc2617 interface is at fault. It should be taking const
unsigned char *, not chat *.

Rob

----- Original Message -----
From: "Henrik Nordstrom" <hno@hem.passagen.se>
To: "Adrian Chadd" <adrian@creative.net.au>
Cc: <squid-dev@squid-cache.org>
Sent: Wednesday, March 07, 2001 9:53 AM
Subject: Re: lib/rfc2617.c

> We SHOULD decide on always use one form or the other of char. Just as
> bitfields char (without a qualifier) is either signed or unsigned,
which
> is up to the compiler used..
>
> In this specific case, a typecast is "the correct thing to do".
>
> /Henrik
>
>
> Adrian Chadd wrote:
> >
> > More cc fun. :)
> >
> > The mipspro cc compiler when using -fullwarn is spitting out
> > the following:
> >
> > cc-1164 cc: WARNING File = rfc2617.c, Line = 108
> > Argument of type "const char *" is incompatible with parameter of
type
> > "const unsigned char *".
> >
> > MD5Update(&Md5Ctx, pszUserName, strlen(pszUserName));
> > ^
> >
> > cc-1164 cc: WARNING File = rfc2617.c, Line = 110
> > Argument of type "const char *" is incompatible with parameter of
type
> > "const unsigned char *".
> >
> > MD5Update(&Md5Ctx, pszRealm, strlen(pszRealm));
> > ^
> > What should we do here? Convert the code to use unsigned char *
> > when doing md5 stuff?
> >
> > Adrian
> >
> > --
> > Adrian Chadd "The fact you can download a 100 megabyte
file
> > <adrian@creative.net.au> from half way around the world should be
viewed
> > as an accident and not a right."
> > -- Adrian Chadd and Bill
Fumerola
>
>
Received on Tue Mar 06 2001 - 15:53:16 MST