>
> >
> > As a side question - this assumes the store dir is on a standard
> > fs - which with coss or some even more esoteric system it may not
> > be. Shouldn't this be a fs module call?
>
> The FS module can call storeDirGetBlkSize() if it wants to. If it
> doesn't want to, there is some default. The FS could set the
> "blocksize" values directly if it wants.
>
> I put it in src/store_dir.c because I *really* hate having the
> same code duplicated through all the FS subdirectories.
>
Sure I hate that too :]. What I meant was - the stats page doesn't call a storefsDirGetBlkSize() which then calls the code you've
written if appropriate. The stats page calls it directly, so it _will_ require new fs drivers to be statsfs-able.
Just my 0.02c
Rob
Received on Thu Jan 04 2001 - 17:23:37 MST
This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:13:09 MST