Re: [PATCH] extract gifs from icons.shar at make time

Robert Collins wrote:
>
> Why are the icons extracted into the source dir?

Because of source distribution tarballs having the icons unpacked from
start, in the source directory, and the install target needs to know
where to look for the icons.

> Howabout we add the
> .PHONY target,
>
> but rather than extracting into the source dir, alter the install line and remove the $(srcdir)/ from it.

A little explanation of .PHONY: It is a magical GNU extension telling
that any direct dependencies are magical targets that does not actually
result in a file. It's purpose is solely to protect make from fucking up
in case a file with that name should accidently be created by the user
(or something else).

The real change proposed was to have the dependency for unpacking the
icons tunneled thru a single target to protect from parallell makes.

$(ICONS):
        @command line

is more or less the same as writing

icon1.gif:
        @command line
icon2.gif:
        @command line
....

and will cause multiple invocations of the command line when doing
parallell builds.

$(ICONS): extract_icons
extract_icons:
        @command line

fixes this by collapsing the dependency tree to a single point before
the command line.

/Henrik
Received on Wed Dec 13 2000 - 18:23:12 MST