Re: cvs commit: squid/auth_modules Makefile.in

These SHOULD NOT be quoted. The variable is a list of words, and if you
quote them then for will read it as a single word. Also, for is defined
in the Unix shell language to handle empty lists fine. However "" is not
a empty list, it is a list with one zero length member.

/Henrik

wessels@squid-cache.org wrote:

> Modified files:
> auth_modules Makefile.in
> Log:
> DW:
> - argh, protect this occurrance also
>
> Revision Changes Path
> 1.3 +1 -1 squid/auth_modules/Makefile.in

> diff -N -u -r -x CVS -x *.orig -x *~ -x *.rej -x *.old -x configure squid.last/auth_modules/Makefile.in squid/auth_modules/Makefile.in
> --- squid.last/auth_modules/Makefile.in Mon May 1 23:14:58 2000
> +++ squid/auth_modules/Makefile.in Thu May 18 21:05:03 2000
> @@ -6,7 +6,7 @@
> SUBDIRS = @AUTH_MODULES@
>

> all:
> - @test -z "$(SUBDIRS)" || for dir in $(SUBDIRS); do \
> + @test -z "$(SUBDIRS)" || for dir in "$(SUBDIRS)"; do \
> sh -c "cd $$dir && $(MAKE) all" || exit 1; \
> done
>
> @@ -26,6 +26,6 @@
> done
>
> .DEFAULT:
> - @test -z "$(SUBDIRS)" || for dir in $(SUBDIRS); do \
> + @test -z "$(SUBDIRS)" || for dir in "$(SUBDIRS)"; do \
> sh -c "cd $$dir && $(MAKE) $@" || exit 1; \
> done
Received on Thu May 18 2000 - 14:10:27 MDT